RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
Xin Liu
xliu at openjdk.java.net
Mon Dec 7 00:19:12 UTC 2020
On Sun, 6 Dec 2020 23:51:20 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> if users don't specify method_name in CompileCommand, hotspot will over consume a token.
>> in debug build, it may hit the assertion of type mismatch.
>
> src/hotspot/share/compiler/methodMatcher.cpp line 282:
>
>> 280: error_msg = "not specify any method pattern";
>> 281: m_match = MethodMatcher::Unknown;
>> 282: bytes_read -= strlen(method_name);
>
> Windows build fails on this with "conversion from 'size_t' to 'int'"
Thanks! I delete this statement because bytes_read will not be used.
The function exits early because of m_match = MethodMatcher::Unknown.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1652
More information about the hotspot-compiler-dev
mailing list