RFR: 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes for AOT

Jie Fu jiefu at openjdk.java.net
Thu Dec 10 11:47:35 UTC 2020


On Thu, 10 Dec 2020 11:19:35 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR fixes a regression caused by JDK-8257917 by not locking JVMCI_lock when initializing the boxing cache classes for AOT.
> 
> It also reduces the calls to `JVMCI::ensure_box_caches_initialized` to be at most one per JVMCI code installation.

src/hotspot/share/jvmci/jvmci.cpp line 131:

> 129: void JVMCI::ensure_box_caches_initialized(Mutex* lock, TRAPS) {
> 130:   MutexLocker locker(lock);
> 131:   // Check again after locking

Shall we remove 'again' in the comment?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1730


More information about the hotspot-compiler-dev mailing list