RFR: 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes for AOT

Jie Fu jiefu at openjdk.java.net
Thu Dec 10 11:54:37 UTC 2020


On Thu, 10 Dec 2020 11:19:35 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR fixes a regression caused by JDK-8257917 by not locking JVMCI_lock when initializing the boxing cache classes for AOT.
> 
> It also reduces the calls to `JVMCI::ensure_box_caches_initialized` to be at most one per JVMCI code installation.

src/hotspot/share/jvmci/jvmciCodeInstaller.cpp line 950:

> 948:   if (_has_auto_box) {
> 949:     JavaThread* THREAD = JavaThread::current();
> 950:     JVMCI::ensure_box_caches_initialized(JVMCI_lock, CHECK_(JVMCI::ok));

Why we can hold JVMCI_lock here.
Does it mean that we'll never initialize the box classes at this point?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1730


More information about the hotspot-compiler-dev mailing list