RFR: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE [v4]

Corey Ashford github.com+51754783+coreyashford at openjdk.java.net
Sat Dec 12 09:17:57 UTC 2020


On Fri, 11 Dec 2020 10:10:37 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Interesting idea!  The point there would be to save the initialization time of loading the address constants?  Otherwise, it has a negative affect on code readability.
>
> Right, we could use much shorter code for loading the constants. I don't think readability would suffer if you only put constants of the same kind (like the base64_... ones) into single arrays. And even if you put all constants into one array I guess it could be made readable by good comments. But there may be a trade-off.

Ok, I will definitely give this a go.  If it looks maintainable, I'll do it.  The loads aren't inside the loop, but still it would be nice especially for calls to the encoder that have a short buffer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1245


More information about the hotspot-compiler-dev mailing list