RFR: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE [v4]
Corey Ashford
github.com+51754783+coreyashford at openjdk.java.net
Mon Dec 14 21:43:11 UTC 2020
On Sat, 12 Dec 2020 09:14:54 GMT, Corey Ashford <github.com+51754783+CoreyAshford at openjdk.org> wrote:
>> Right, we could use much shorter code for loading the constants. I don't think readability would suffer if you only put constants of the same kind (like the base64_... ones) into single arrays. And even if you put all constants into one array I guess it could be made readable by good comments. But there may be a trade-off.
>
> Ok, I will definitely give this a go. If it looks maintainable, I'll do it. The loads aren't inside the loop, but still it would be nice especially for calls to the encoder that have a short buffer.
I have pushed changes for this issue. Take a look and see if you agree that what I did is acceptable, especially with respect to the hard-coded offsets. I'd be interested to hear If you have a better idea about to maintain them.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1245
More information about the hotspot-compiler-dev
mailing list