RFR: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE [v4]

Corey Ashford github.com+51754783+coreyashford at openjdk.java.net
Tue Dec 15 20:05:03 UTC 2020


On Tue, 15 Dec 2020 14:26:24 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> I have pushed changes for this issue.  Take a look and see if you agree that what I did is acceptable, especially with respect to the hard-coded offsets.  I'd be interested to hear If you have a better idea about to maintain them.
>
> It'd be possible to put them into a struct and have the offsets computed by the C++ compiler, but I'm fine with your version. I guess there won't be many manual changes any more.
> I'll test the code a bit longer, but it looks good so far.

Oh, that's a great idea!  I'm willing to make that change, if you don't mind one last cycle of review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1245


More information about the hotspot-compiler-dev mailing list