RFR: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE [v4]

Tue Dec 15 14:28:57 UTC 2020

On Mon, 14 Dec 2020 21:40:06 GMT, Corey Ashford <github.com+51754783+CoreyAshford at openjdk.org> wrote:

>> Ok, I will definitely give this a go.  If it looks maintainable, I'll do it.  The loads aren't inside the loop, but still it would be nice especially for calls to the encoder that have a short buffer.
>
> I have pushed changes for this issue.  Take a look and see if you agree that what I did is acceptable, especially with respect to the hard-coded offsets.  I'd be interested to hear If you have a better idea about to maintain them.

It'd be possible to put them into a struct and have the offsets computed by the C++ compiler, but I'm fine with your version. I guess there won't be many manual changes any more.
I'll test the code a bit longer, but it looks good so far.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1245