[15] RFR(XS): 8238756: C2: assert(((n) == __null || !VerifyIterativeGVN || !((n)->is_dead()))) failed: can not use dead node

[Nils Eliasson]

Hi Christian,

I your fix for 8238811 you added a test "TestVerifyGraphEdges" doing 
Xcomp on a simple method to get some basic testing for that flag. Have 
you considered that for -XX:+VerifyIterativeGVN too?

Otherwise it looks good.

Best regards,
Nils Eliasson

On 2020-02-12 09:05, Christian Hagedorn wrote:
> Hi
>
> Please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8238756
> http://cr.openjdk.java.net/~chagedorn/8238756/webrev.00/
>
> The dead hook node is set as an input to the phi node in 
> replace_edge(), letting the assertion of set_req() fail with 
> VerifyIterativeGVN. I suggest to just set a dummy input to prevent the 
> hook from being dead.
>
> Thank you!
>
> Best regards,
> Christian