[15] RFR(XS): 8238756: C2: assert(((n) == __null || !VerifyIterativeGVN || !((n)->is_dead()))) failed: can not use dead node

[Christian Hagedorn]

Hi Nils

Thank you for your review!

That's a good idea. I added a similar test with a larger timeout (just 
to be sure since it's quite time consuming) to the current webrev.

Best regards,
Christian

On 12.02.20 11:33, Nils Eliasson wrote:
> Hi Christian,
> 
> I your fix for 8238811 you added a test "TestVerifyGraphEdges" doing 
> Xcomp on a simple method to get some basic testing for that flag. Have 
> you considered that for -XX:+VerifyIterativeGVN too?
> 
> Otherwise it looks good.
> 
> Best regards,
> Nils Eliasson
> 
> On 2020-02-12 09:05, Christian Hagedorn wrote:
>> Hi
>>
>> Please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8238756
>> http://cr.openjdk.java.net/~chagedorn/8238756/webrev.00/
>>
>> The dead hook node is set as an input to the phi node in 
>> replace_edge(), letting the assertion of set_req() fail with 
>> VerifyIterativeGVN. I suggest to just set a dummy input to prevent the 
>> hook from being dead.
>>
>> Thank you!
>>
>> Best regards,
>> Christian
>