[15] RFR(M): 8240227: Loop predicates should be copied to unswitched loops

Tobias Hartmann tobias.hartmann at oracle.com
Mon Mar 16 10:56:05 UTC 2020


Hi Christian,

On 13.03.20 13:10, Christian Hagedorn wrote:
>> - loopPredicate.cpp:415/422 Why are two versions of PhaseIdealLoop::clone_loop_predicates required?
> 
> There was originally a method PhaseIterGVN::clone_loop_predicates which did not have any uses. I
> removed it in the current webrev. But in addition, we can also remove one of those remaining
> clone_loop_predicates methods which is not required anymore and make all involved methods
> non-static. I removed all related dead code.

Nice!

> I created new updated webrevs with the cleaned up code:
> Full: http://cr.openjdk.java.net/~chagedorn/8240227/webrev.01/
> Inc: http://cr.openjdk.java.net/~chagedorn/8240227/webrev.00-01/

Looks good!

Best regards,
Tobias


More information about the hotspot-compiler-dev mailing list