[15] RFR(M): 8240227: Loop predicates should be copied to unswitched loops

[Christian Hagedorn]

Thank you Tobias for your review!

Best regards,
Christian

On 16.03.20 11:56, Tobias Hartmann wrote:
> Hi Christian,
> 
> On 13.03.20 13:10, Christian Hagedorn wrote:
>>> - loopPredicate.cpp:415/422 Why are two versions of PhaseIdealLoop::clone_loop_predicates required?
>>
>> There was originally a method PhaseIterGVN::clone_loop_predicates which did not have any uses. I
>> removed it in the current webrev. But in addition, we can also remove one of those remaining
>> clone_loop_predicates methods which is not required anymore and make all involved methods
>> non-static. I removed all related dead code.
> 
> Nice!
> 
>> I created new updated webrevs with the cleaned up code:
>> Full: http://cr.openjdk.java.net/~chagedorn/8240227/webrev.01/
>> Inc: http://cr.openjdk.java.net/~chagedorn/8240227/webrev.00-01/
> 
> Looks good!
> 
> Best regards,
> Tobias
>