[aarch64-port-dev ] [15] RFR (L): 8241436: C2: Factor out C2-specific code from MacroAssembler

[Andrew Haley]

> On 23.03.2020 16:49, Vladimir Ivanov wrote:
>> http://cr.openjdk.java.net/~vlivanov/8241436/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8241436
>>
>> (The patch is built on top of 8240248 [1].)
>>
>> MacroAssembler has C2-only declarations and the number is growing over
>> time.
>>
>> C1 and template interpreter already subclass MacroAssembler for their
>> own needs (C1_MacroAssembler and InterpreterMacroAssembler respectively).
>>
>> I propose to introduce C2_MacroAssembler, move C2-specific code there,
>> and use it exclusively across C2 code base.

This is interesting.

What are all of the changes in aarch64.ad for? Only three functions
have been moved to C2_MacroAssembler.

Do you distinguish between MacroAssembler functions that are
C2-specific and those that are really general purpose but have
hitherto only been used in C2?

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671