[aarch64-port-dev ] [15] RFR (L): 8241436: C2: Factor out C2-specific code from MacroAssembler

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed Mar 25 10:18:03 UTC 2020


Thanks for taking a look, Andrew!

>>> I propose to introduce C2_MacroAssembler, move C2-specific code there,
>>> and use it exclusively across C2 code base.
> 
> This is interesting.
> 
> What are all of the changes in aarch64.ad for? Only three functions
> have been moved to C2_MacroAssembler.
> 
> Do you distinguish between MacroAssembler functions that are
> C2-specific and those that are really general purpose but have
> hitherto only been used in C2?

I don't. The patch uniformly migrates C2 code to C2_MacroAssembler 
irrespective of whether C2-specific code is used or not.

It's keeps status quo with MacroAssembler vs Assembler separation: 
MacroAssembler has been used irrespective of whether any MA-specific 
declarations are needed or not.

Best regards,
Vladimir Ivanov


More information about the hotspot-compiler-dev mailing list