RFR(T/S): 8236975 "compiler/graalunit tests fails with --illegal-access=deny"

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 26 08:11:06 UTC 2020


On 25/03/2020 22:04, Ekaterina Pavlova wrote:
> Hello,
>
> Please review the changes which allow to specify additional VM flags 
> to be used to run particular Graal unit tests.
> The fix makes Graal unit tests which previously failed with 
> --illegal-access=deny to pass now.
>
>
>       JBS: https://bugs.openjdk.java.net/browse/JDK-8206113
>    webrev: 
> http://cr.openjdk.java.net/~epavlova//8236975/webrev.00/index.html
>   testing: run graalunit tests with and without 
> "--illegal-access=deny" flag in mach5
The jtreg way to do this is `@modules java.base/java.lang:+open` and it 
would run the test with --add-open java.base/java.lang=ALL-UNNAMED. Is 
the reason for the approach in the webrev because the options aren't 
passed through to the VM run using the Graal compiler?  They look okay 
of course and if you want to avoid using :SPACE then you can use '=' as 
an alternative (JEP 293 has more on this).

-Alan


More information about the hotspot-compiler-dev mailing list