[aarch64-port-dev ] RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

[Christian Hagedorn]

Hi Andrew

On 5/6/20 8:26 AM, Christian Hagedorn wrote
>> [..] since MacroAssembler::debug64() set up those arguments [..]

Sorry, I mixed that up. I meant that MacroAssembler::stop() on x86 
emitted those additional instructions as arguments needed by debug64(). 
This was then guarded by ShowMessageBoxOnError to only emit the message 
argument for debug64() by default.

On 06.05.20 10:40, Andrew Haley wrote:
> On 5/6/20 8:26 AM, Christian Hagedorn wrote
>> The fix was to
>> only do it if ShowMessageBoxOnError was set. So, I think it's indeed a
>> good idea to also do the same for other architectures.
> 
> Really? Can't we fix stop() so that it generates only a tiny little bit
> of code? I can do it if you like.

This is probably what you've meant. I agree with you, the fewer 
instructions emitted by stop() the better.

Best regards,
Christian