[aarch64-port-dev ] RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

[Andrew Haley]

On 5/6/20 10:14 AM, Christian Hagedorn wrote:
> On 06.05.20 10:40, Andrew Haley wrote:
>> On 5/6/20 8:26 AM, Christian Hagedorn wrote
>>> The fix was to
>>> only do it if ShowMessageBoxOnError was set. So, I think it's indeed a
>>> good idea to also do the same for other architectures.
>> Really? Can't we fix stop() so that it generates only a tiny little bit
>> of code? I can do it if you like.
> This is probably what you've meant. I agree with you, the fewer 
> instructions emitted by stop() the better.

ShowMessageBoxOnError is completely the wrong thing to use. I run
in GDB all the time, and I want accurate error messages, and I never
use ShowMessageBoxOnError. If we get this right we can have near-zero
code expansion, and keep this on at all times, even in production.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671