RFR: 8256857: ARM32 builds broken after JDK-8254231 [v3]

Jorn Vernee jvernee at openjdk.java.net
Mon Nov 23 15:21:17 UTC 2020


On Mon, 23 Nov 2020 15:06:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> LGTM.
>> 
>> Though, note that the style guide asks to prefer `nullptr` to `NULL`: https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#nullptr
>> 
>> nullptr
>> 
>> Prefer nullptr (n2431) to NULL. Don't use (constexpr or literal) 0 for pointers.
>> 
>> For historical reasons there are widespread uses of both NULL and of integer 0 as a pointer value.
>
>> Though, note that the style guide asks to prefer `nullptr` to `NULL`: https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#nullptr
> 
> Fixed. Please push your Zero integration first, and then I rebase this one?

@shipilev Done. Though I'm not a `jdk` Reviewer, so another review is needed for this PR.

But, as the person most familiar with the code, it looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1383


More information about the hotspot-compiler-dev mailing list