RFR: 8256860: S390 builds broken after JDK-8254231

Thomas Stuefe stuefe at openjdk.java.net
Mon Nov 23 16:24:00 UTC 2020


On Mon, 23 Nov 2020 15:38:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Foreign linker integration broke S390 builds. This change stubs out the new entry points, without implementing the actual support yet.
> 
> Additional testing:
>  - [x] Linux s390x fastdebug cross-compilation

IIUC JDK-8254231 implements support for aarch and x84, which leaves all other architectures (s390, arm, ppc, broken? Thats... :-(

Thanks a lot for fixing! If your patch fixes the build without having to stub out `ABIDescriptor::is_volatile_reg`, feel free to push.

Cheers, Thomas

src/hotspot/cpu/s390/foreign_globals_s390.cpp line 36:

> 34:   Unimplemented();
> 35:   return {};
> 36: }

Wont we need stubs for `ABIDescriptor::is_volatile_reg` too?

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1392


More information about the hotspot-compiler-dev mailing list