RFR: 8256860: S390 builds broken after JDK-8254231

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 23 17:05:57 UTC 2020


On Mon, 23 Nov 2020 16:15:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Foreign linker integration broke S390 builds. This change stubs out the new entry points, without implementing the actual support yet.
>> 
>> Additional testing:
>>  - [x] Linux s390x fastdebug cross-compilation
>
> src/hotspot/cpu/s390/foreign_globals_s390.cpp line 36:
> 
>> 34:   Unimplemented();
>> 35:   return {};
>> 36: }
> 
> Wont we need stubs for `ABIDescriptor::is_volatile_reg` too?

No other arch needs it, and `s390x` builds fine for me without. AFAICS from the current code, `ABIDescriptor::is_volatile_reg` is only used from the arch-specific implementations of `universalNativeInvoker` and `universalUpcallHandler`. Which are stubbed out for `s390x`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1392


More information about the hotspot-compiler-dev mailing list