RFR: 8256924: ppc, ppcle, s390: JVM crashes at VM init after JDK-8254231

[Aleksey Shipilev]

On Tue, 24 Nov 2020 14:46:07 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Some parts of methodHandles_<platform>.cpp and sharedRuntime_<platform>.cpp are missing. VM is crashing because vmIntrinsics::_invokeBasic is not yet handled.
> Note that C2 compiler still has issues on PPC64.

This look okay to me. Consider fixing a minor nit.

src/hotspot/cpu/ppc/methodHandles_ppc.cpp line 319:

> 317:     if (iid == vmIntrinsics::_linkToNative) {
> 318:       assert(for_compiler_entry, "only compiler entry is supported");
> 319:     }

I believe it is customary to write conditional asserts like:
  assert(for_compiler_entry || iid != vmIntrinsics::_linkToNative, "only compiler entry is supported for linkToNative")

...same thing for S390.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1411