RFR: 8256924: ppc, ppcle, s390: JVM crashes at VM init after JDK-8254231

[Martin Doerr]

On Tue, 24 Nov 2020 15:52:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Some parts of methodHandles_<platform>.cpp and sharedRuntime_<platform>.cpp are missing. VM is crashing because vmIntrinsics::_invokeBasic is not yet handled.
>> Note that C2 compiler still has issues on PPC64.
>
> src/hotspot/cpu/ppc/methodHandles_ppc.cpp line 319:
> 
>> 317:     if (iid == vmIntrinsics::_linkToNative) {
>> 318:       assert(for_compiler_entry, "only compiler entry is supported");
>> 319:     }
> 
> I believe it is customary to write conditional asserts like:
>   assert(for_compiler_entry || iid != vmIntrinsics::_linkToNative, "only compiler entry is supported for linkToNative")
> 
> ...same thing for S390.

Thanks for reviewing it!
I've copied the code from x86 and I'd prefer to keep it consistent even though I like your version more. Are you ok with it?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1411