RFR: 8254360: Re-examine use of CodeBuffer::verify_section_allocation

[Tobias Hartmann]

On Tue, 24 Nov 2020 23:36:22 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> - In release builds, only call `verify_section_allocation` in `~CodeBuffer`. This reduce overhead, while retaining most of the verification promises in product builds.
> - Minor touch-ups the implementation of `verify_section_allocation`: Use is_aligned. Add a `disjoint` predicate. Only compare two sections once per verification. Remove some redundant checks.

Looks good to me.

src/hotspot/share/asm/codeBuffer.cpp line 959:

> 957:     CodeSection* sect = code_section(n);
> 958:     if (!sect->is_allocated() || sect->is_empty()) {
> 959:        continue;

Indentation is wrong.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1421