RFR: 8254360: Re-examine use of CodeBuffer::verify_section_allocation [v2]

Claes Redestad redestad at openjdk.java.net
Wed Nov 25 15:13:15 UTC 2020


On Wed, 25 Nov 2020 14:51:35 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Fix copyright
>>  - Fix indentation, copyright
>>  - Merge branch 'master' into verify_section_alloc
>>  - Merge branch 'master' into verify_section_alloc
>>  - Merge branch 'master' into verify_section_alloc
>>  - Ptrs schmtrs
>>  - Factor out disjoint property, avoid redundant checks (disjointedness is symmetric)
>>  - 8254360: Re-examine use of CodeBuffer::verify_section_allocation
>
> src/hotspot/share/asm/codeBuffer.cpp line 959:
> 
>> 957:     CodeSection* sect = code_section(n);
>> 958:     if (!sect->is_allocated() || sect->is_empty()) {
>> 959:        continue;
> 
> Indentation is wrong.

Good catch!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1421


More information about the hotspot-compiler-dev mailing list