RFR: 8254360: Re-examine use of CodeBuffer::verify_section_allocation [v2]

[Claes Redestad]

On Wed, 25 Nov 2020 19:32:30 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Fix copyright
>>  - Fix indentation, copyright
>>  - Merge branch 'master' into verify_section_alloc
>>  - Merge branch 'master' into verify_section_alloc
>>  - Merge branch 'master' into verify_section_alloc
>>  - Ptrs schmtrs
>>  - Factor out disjoint property, avoid redundant checks (disjointedness is symmetric)
>>  - 8254360: Re-examine use of CodeBuffer::verify_section_allocation
>
> src/hotspot/share/asm/codeBuffer.hpp line 494:
> 
>> 492:     initialize_misc("static buffer");
>> 493:     initialize(code_start, code_size);
>> 494:     debug_only(verify_section_allocation();)
> 
> You also need #ifdef ASSERT around verify_section_allocation() in codeBuffer.cpp.

There's still a verification in product code in `CodeBuffer::~CodeBuffer()`. Or do we want to take leap and make this ASSERT-only altogether?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1421