RFR: 8254360: Re-examine use of CodeBuffer::verify_section_allocation [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Wed Nov 25 19:53:57 UTC 2020
On Wed, 25 Nov 2020 19:41:13 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> src/hotspot/share/asm/codeBuffer.hpp line 494:
>>
>>> 492: initialize_misc("static buffer");
>>> 493: initialize(code_start, code_size);
>>> 494: debug_only(verify_section_allocation();)
>>
>> You also need #ifdef ASSERT around verify_section_allocation() in codeBuffer.cpp.
>
> There's still a verification in product code in `CodeBuffer::~CodeBuffer()`. Or do we want to take leap and make this ASSERT-only altogether?
But you put debug_only() around declaration here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1421
More information about the hotspot-compiler-dev
mailing list