RFR: 8257190: simplify PhaseIdealLoop constructors
Tobias Hartmann
thartmann at openjdk.java.net
Mon Nov 30 10:38:57 UTC 2020
On Fri, 27 Nov 2020 00:07:53 GMT, Xin Liu <xliu at openjdk.org> wrote:
> 8257190: simplify PhaseIdealLoop constructors
Otherwise looks good to me.
src/hotspot/share/opto/loopnode.hpp line 955:
> 953: // Perform verification that the graph is valid when verify_me is nullptr
> 954: // Verify that verify_me made the same decisions as a fresh run.
> 955: PhaseIdealLoop(PhaseIterGVN& igvn, const PhaseIdealLoop* verify_me = nullptr) :
I think the comment should be something like:
// Verify that verify_me made the same decisions as a fresh run
// or only verify that the graph is valid if verify_me is null.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1473
More information about the hotspot-compiler-dev
mailing list