RFR: 8257190: simplify PhaseIdealLoop constructors [v2]

[Xin Liu]

On Mon, 30 Nov 2020 10:35:50 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8257190
>>  - 8257190: simplify PhaseIdealLoop constructors
>>    
>>    update the comments of the verify constructors.
>>  - 8257190: simplify PhaseIdealLoop constructors
>
> src/hotspot/share/opto/loopnode.hpp line 955:
> 
>> 953:   // Perform verification that the graph is valid when verify_me is nullptr
>> 954:   // Verify that verify_me made the same decisions as a fresh run.
>> 955:   PhaseIdealLoop(PhaseIterGVN& igvn, const PhaseIdealLoop* verify_me = nullptr) :
> 
> I think the comment should be something like:
> // Verify that verify_me made the same decisions as a fresh run
> // or only verify that the graph is valid if verify_me is null.

hi, Tobias, 
thanks for reviewing it. I update the comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1473