RFR: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"

Mon Oct 19 20:19:14 UTC 2020

On Mon, 19 Oct 2020 10:14:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Static analyzers complain `call_offset` might not be initialized in `StubAssembler::call_RT` in `c1_Runtime1_x86.cpp`.
> The way I see it, it depends on `align_stack` value, and it is set whether it `align_stack` is `true` or `false`. But
> we can probably make it cleaner so that future errors would be clearly detectable. Since it is initialized off
> `offset()`, it should not be negative.  Testing:
>  - [x] Linux x86_64 tier1

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/730