Integrated: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"

Aleksey Shipilev shade at openjdk.java.net
Tue Oct 20 05:35:08 UTC 2020


On Mon, 19 Oct 2020 10:14:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Static analyzers complain `call_offset` might not be initialized in `StubAssembler::call_RT` in `c1_Runtime1_x86.cpp`.
> The way I see it, it depends on `align_stack` value, and it is set whether it `align_stack` is `true` or `false`. But
> we can probably make it cleaner so that future errors would be clearly detectable. Since it is initialized off
> `offset()`, it should not be negative.  Testing:
>  - [x] Linux x86_64 tier1

This pull request has now been integrated.

Changeset: 355f44dd
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/355f44dd
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"

Reviewed-by: chagedorn, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/730


More information about the hotspot-compiler-dev mailing list