RFR: 8241495: Make more compiler related flags available on a per method level [v2]
Xin Liu
xliu at openjdk.java.net
Mon Oct 26 23:02:19 UTC 2020
On Thu, 22 Oct 2020 09:06:47 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:
>> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>>
>> 8241495: Make more compiler related flags available on a per method level
>
> src/hotspot/share/compiler/compilerDirectives.hpp line 39:
>
>> 37: cflags(Enable, bool, false, Enable) \
>> 38: cflags(Exclude, bool, false, Exclude) \
>> 39: cflags(BreakAtExecute, bool, false, BreakAtExecute) \
>
> The BreakAtFlags are missing defaults since CompileCommand uses the "break" option. If we are going to add them to the directives - we should go through all uses and make sure that this is the only flag is uses.
break can't distinct breatAtCompile or breatAtExecution. I think it's good idea to separate them.
Debugging the parser or optimizations needs the first. The developers who debug codegen need the second one.
Currently, directive->breakAtCompile and directive->breakAtExecution are in use. Even BreakCommand is translated into them.
There's a cleanup JDK-8255216. that's another task I will follow.
-------------
PR: https://git.openjdk.java.net/jdk/pull/796
More information about the hotspot-compiler-dev
mailing list