RFR: 8241495: Make more compiler related flags available on a per method level [v2]

Xin Liu xliu at openjdk.java.net
Tue Oct 27 03:04:22 UTC 2020


On Thu, 22 Oct 2020 09:04:43 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8241495: Make more compiler related flags available on a per method level
>
> src/hotspot/share/compiler/compilerDirectives.hpp line 37:
> 
>> 35:   //      Directives flag name,    type, default value, compile command name
>> 36:   #define compilerdirectives_common_flags(cflags) \
>> 37:     cflags(Enable,                  bool, false, Enable) \
> 
> This flag only has a meaning when working with directives files. Doesn't it just add confusion to have a default from CompileCommand?

agree. take it off.

-------------

PR: https://git.openjdk.java.net/jdk/pull/796


More information about the hotspot-compiler-dev mailing list