RFR: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…

Aleksey Shipilev shade at openjdk.java.net
Thu Sep 10 08:01:47 UTC 2020


On Thu, 10 Sep 2020 07:48:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> …pport"
> 
> Hi,
> 
> this change fixes the issues after 8231441.  The VM crashes right in the build after this change.
> The fix is trivial.
> 
> Please review.

Marked as reviewed by shade (Reviewer).

src/hotspot/share/opto/type.cpp line 65:

> 63:
> 64: #if defined(PPC64)
> 65:   { Bad,             T_ILLEGAL,    "vectora:",      false, Op_VecA,              relocInfo::none          },  //
> VectorA.

I think trailing "." in the comment is unnecessary. Please consider dropping before push.

src/hotspot/share/opto/type.cpp line 72:

> 70:   { Bad,             T_ILLEGAL,    "vectorz:",      false, 0,                    relocInfo::none          },  //
> VectorZ 71: #elif defined(S390)
> 72:   { Bad,             T_ILLEGAL,    "vectora:",      false, Op_VecA,              relocInfo::none          },  //
> VectorA.

I think trailing "." in the comment is unnecessary. Please consider dropping before push.

-------------

PR: https://git.openjdk.java.net/jdk/pull/105


More information about the hotspot-compiler-dev mailing list