RFR: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…

Goetz Lindenmaier goetz at openjdk.java.net
Thu Sep 10 08:17:55 UTC 2020


On Thu, 10 Sep 2020 07:58:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> …pport"
>> 
>> Hi,
>> 
>> this change fixes the issues after 8231441.  The VM crashes right in the build after this change.
>> The fix is trivial.
>> 
>> Please review.
>
> src/hotspot/share/opto/type.cpp line 65:
> 
>> 63:
>> 64: #if defined(PPC64)
>> 65:   { Bad,             T_ILLEGAL,    "vectora:",      false, Op_VecA,              relocInfo::none          },  //
>> VectorA.
> 
> I think trailing "." in the comment is unnecessary. Please consider dropping before push.

Hi Aleksey, I would not have put a dot there, but I just copied the line from the #else part which also has the dot.
So I'd rather leave it as-is.
Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/105


More information about the hotspot-compiler-dev mailing list