RFR: 8253002: Remove the unused SafePointNode::_oop_map field [v2]

[Tobias Hartmann]

On Tue, 15 Sep 2020 09:29:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> I've been looking a lot at the code for generating oop maps for call nodes lately, and noticed that SafePointNode had
>> an oopMap field that was unused (which led to some confusion as to where the oop map was actually set).
>> The oop map is instead generated and set in buildOopMap OopFlow::compute_reach after matching:
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/buildOopMap.cpp#L122 So the field on the ideal node
>> is unused.  This patch removes the field and cleans up related code. I've left a comment in SafePointNode to point
>> people looking for the oop map at buildOopMap.cpp
>> Thanks,
>> Jorn
>> 
>> Testing: local build + tier1,tier2,tier3
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments:
>   - Remove comment in SafePointNode
>   - Remove forward declaration of class OopMap

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/109