Integrated: 8253002: Remove the unused SafePointNode::_oop_map field

Jorn Vernee jvernee at openjdk.java.net
Tue Sep 15 12:26:26 UTC 2020


On Thu, 10 Sep 2020 10:17:42 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> I've been looking a lot at the code for generating oop maps for call nodes lately, and noticed that SafePointNode had
> an oopMap field that was unused (which led to some confusion as to where the oop map was actually set).
> The oop map is instead generated and set in buildOopMap OopFlow::compute_reach after matching:
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/buildOopMap.cpp#L122 So the field on the ideal node
> is unused.  This patch removes the field and cleans up related code. I've left a comment in SafePointNode to point
> people looking for the oop map at buildOopMap.cpp
> Thanks,
> Jorn
> 
> Testing: local build + tier1,tier2,tier3

This pull request has now been integrated.

Changeset: d219d8b9
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d219d8b9
Stats:     8 lines in 2 files changed: 8 ins; 0 del; 0 mod

8253002: Remove the unused SafePointNode::_oop_map field

Reviewed-by: thartmann

-------------

PR: https://git.openjdk.java.net/jdk/pull/109


More information about the hotspot-compiler-dev mailing list