RFR: 8253524: C2: Refactor code that clones predicates during loop unswitching [v3]

Roland Westrelin roland at openjdk.java.net
Thu Sep 24 06:49:36 UTC 2020


> During unswitching, PhaseIdealLoop::create_slow_version_of_loop()
> calls PhaseIdealLoop::clone_predicates_to_unswitched_loop() twice, one
> for each loops, to clone some predicates above each loop. That code is
> fragile as it (implicitly) requires the fast loop to be processed
> first. I propose calling
> PhaseIdealLoop::clone_predicates_to_unswitched_loop() a single time
> and have it handle both loops in a single pass.

Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:

  extra space

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/317/files
  - new: https://git.openjdk.java.net/jdk/pull/317/files/5ab947eb..93f33e9b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=317&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=317&range=01-02

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/317.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/317/head:pull/317

PR: https://git.openjdk.java.net/jdk/pull/317


More information about the hotspot-compiler-dev mailing list