RFR: 8253524: C2: Refactor code that clones predicates during loop unswitching [v4]

Roland Westrelin roland at openjdk.java.net
Thu Sep 24 08:35:42 UTC 2020


> During unswitching, PhaseIdealLoop::create_slow_version_of_loop()
> calls PhaseIdealLoop::clone_predicates_to_unswitched_loop() twice, one
> for each loops, to clone some predicates above each loop. That code is
> fragile as it (implicitly) requires the fast loop to be processed
> first. I propose calling
> PhaseIdealLoop::clone_predicates_to_unswitched_loop() a single time
> and have it handle both loops in a single pass.

Roland Westrelin has refreshed the contents of this pull request, and previous commits have been removed. The
incremental views will show differences compared to the previous content of the PR. The pull request contains one new
commit since the last revision:

  extra space

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/317/files
  - new: https://git.openjdk.java.net/jdk/pull/317/files/93f33e9b..33fb2fe2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=317&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=317&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/317.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/317/head:pull/317

PR: https://git.openjdk.java.net/jdk/pull/317


More information about the hotspot-compiler-dev mailing list