RFR: 8253689: [s390] Use flag kind diagnostic for platform specific flags

Thomas Stuefe stuefe at openjdk.java.net
Wed Sep 30 06:54:58 UTC 2020


On Tue, 29 Sep 2020 20:52:17 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Current platform implementation (globals_s390.hpp) uses regular product flags for everything.
> These platform specific flags were never intended for official support. They are only there to diagnose issues and find
> workarounds. So flag kind "diagnostic" fits better.
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8253691

Hi Martin,

looks simple enough. Make sure that all scripts and tests (also our internal? eg benchmarks) now
pass -XX:+UnlockDiagnosticVMOptions.

Cheers, Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/414


More information about the hotspot-compiler-dev mailing list