RFR: 8253689: [s390] Use flag kind diagnostic for platform specific flags

[Martin Doerr]

On Wed, 30 Sep 2020 06:52:15 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Current platform implementation (globals_s390.hpp) uses regular product flags for everything.
>> These platform specific flags were never intended for official support. They are only there to diagnose issues and find
>> workarounds. So flag kind "diagnostic" fits better.
>> 
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8253691
>
> Hi Martin,
> 
> looks simple enough. Make sure that all scripts and tests (also our internal? eg benchmarks) now
> pass -XX:+UnlockDiagnosticVMOptions.
> Cheers, Thomas

Hi Thomas,

thanks for the review. I haven't found any tests which use one of these switches. Our tests have passed.

Best regards,
Martin

-------------

PR: https://git.openjdk.java.net/jdk/pull/414