RFR: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode [v2]
Igor Ignatyev
iignatyev at openjdk.java.net
Tue Apr 27 20:26:38 UTC 2021
> Hi all,
>
> could you please review this tiny patch for `TestPrintOptoAssemblyLineNumbers` test?
> from JBS:
>> compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.
>
> besides addressing this, the patch also removes `/compiler/patches` from `@library` as it's not needed and fixes code style here and there.
>
> testing:
> - [x] `compiler/arguments/TestPrintOptoAssemblyLineNumbers` on `{linux,windows,macosx}-x64-debug`
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with four additional commits since the last revision:
- added oracle copyright line
- and one more space
- "mark" test as sensitive to line numbers
- use OutputAnalyzer to check stdout
check exit code
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3726/files
- new: https://git.openjdk.java.net/jdk/pull/3726/files/1e37f7b3..d4b342a9
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3726&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3726&range=00-01
Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod
Patch: https://git.openjdk.java.net/jdk/pull/3726.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3726/head:pull/3726
PR: https://git.openjdk.java.net/jdk/pull/3726
More information about the hotspot-compiler-dev
mailing list