RFR: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode [v2]

Vladimir Kozlov kvn at openjdk.java.net
Tue Apr 27 20:26:38 UTC 2021


On Tue, 27 Apr 2021 20:22:47 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this tiny patch for `TestPrintOptoAssemblyLineNumbers` test? 
>> from JBS:
>>> compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.
>> 
>> besides addressing this, the patch also removes `/compiler/patches` from `@library` as it's not needed and fixes code style here and there.
>> 
>> testing:
>> - [x] `compiler/arguments/TestPrintOptoAssemblyLineNumbers` on `{linux,windows,macosx}-x64-debug`
>> 
>> Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - added oracle copyright line
>  - and one more space
>  - "mark" test as sensitive to line numbers
>  - use OutputAnalyzer to check stdout
>    check exit code

Add Oracle copyright line.

test/hotspot/jtreg/compiler/arguments/TestPrintOptoAssemblyLineNumbers.java line 67:

> 65:         public static void main(String[] args) {
> 66:             int count = 0;
> 67:             for (int x = 0; x < 200_000; x++){

Missed space between `){`

-------------

Changes requested by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3726


More information about the hotspot-compiler-dev mailing list