RFR: 8265956: JVM crashes when matching LShiftVB Node [v2]

[Wang Huang]

On Thu, 29 Apr 2021 09:16:04 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add m4 file
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorShuffleIotaShort.java line 44:
> 
>> 42:     static short[] as = {87, 65, 78, 71, 72, 69, 82, 69};
>> 43: 
>> 44:     public static void testShuffleS() {
> 
> IMO, this test is not enough since the assembly code is not easy to get reviewed.
> 
> So I suggest to improve your test:
>  1) Test as many match-patterns you added as possible
>  2) Verify the results in your tests
> 
> Thanks.

@DamonFool I will add  other vector lengths here. Thank you for your review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3747