RFR: 8278104: C1 should support the compiler directive 'BreakAtExecute'
Xin Liu
xliu at openjdk.java.net
Tue Dec 14 06:29:21 UTC 2021
On Sun, 12 Dec 2021 04:21:51 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> Currently, the directive `BreakAtExecute` is not effective at C1. And the `CompileCommand=break` doesn't break the compiled method, too. This patch unifies the `BreakAtExecute` and `CompileCommand=break` to the directive 'BreakAtExecute' and uses the directive 'BreakAtExecute' to identify whether a breakpoint should be added.
>
> The test group `hotspot_compiler` passed locally.(linux x86_64 fastdebug)
> And the pre-submit tests passed before submitting the PR.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
LGTM.
I am not a reviewer. We still need other reviewers to approve it.
hi, @lgxbslgx
your patch looks good to me.
-------------
Marked as reviewed by xliu (Committer).
PR: https://git.openjdk.java.net/jdk/pull/6807
More information about the hotspot-compiler-dev
mailing list