RFR: 8278104: C1 should support the compiler directive 'BreakAtExecute'

Guoxiong Li gli at openjdk.java.net
Wed Dec 15 02:58:59 UTC 2021


On Tue, 14 Dec 2021 06:24:21 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently, the directive `BreakAtExecute` is not effective at C1. And the `CompileCommand=break` doesn't break the compiled method, too. This patch unifies the `BreakAtExecute` and `CompileCommand=break` to the directive 'BreakAtExecute' and uses the directive 'BreakAtExecute' to identify whether a breakpoint should be added.
>> 
>> The test group `hotspot_compiler` passed locally.(linux x86_64 fastdebug)
>> And the pre-submit tests passed before submitting the PR.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> hi, @lgxbslgx 
> your patch looks good to me.

@navyxliu Thanks for your review. Still waiting for other reviewers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6807


More information about the hotspot-compiler-dev mailing list