RFR: JDK-8258603 c1 IR::verify is expensive [v3]

Thu Dec 16 16:42:37 UTC 2021

On Thu, 16 Dec 2021 10:40:15 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup2
>
> I think it's a good idea to narrow the verification down to the blocks which are actually changed and also add some additional verification steps. Even with the newly added checks, it should still be better than running a complete check each time. Did you observe a big gain in the C1 compilation time for debug builds with your new patch? Maybe you also want to check again with the tests from https://github.com/openjdk/jdk16/pull/44.

@chhagedorn I believe I have addressed all your comments now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850