RFR: JDK-8258603 c1 IR::verify is expensive [v5]

[Vladimir Kozlov]

On Wed, 15 Dec 2021 16:43:10 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   flip ifs
>
> src/hotspot/share/c1/c1_Optimizer.cpp line 183:
> 
>> 181:   }
>> 182: 
>> 183: #ifdef ASSERT
> 
> `expand_with_neighborhood()` is guarded with `ifndef PRODUCT`. You should use the same here.

No, `#ifdef ASSERT` is good here. `blocks_to_verify_later` was processed before by `IR::verify()` only in debug build (method's code was under `#ifdef ASSERT`). Now it passed to `IR::verify_local()` which is called only debug build.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850