RFR: JDK-8258603 c1 IR::verify is expensive [v5]

[Albert Mingkun Yang]

On Fri, 17 Dec 2021 15:42:09 GMT, Ludvig Janiuk <duke at openjdk.java.net> wrote:

>> IR::verify iterates the whole object graph. This proves costly when used in e.g. BlockMerger inside of iterations over BlockLists, leading to quadratic or worse complexities as a function of bytecode length. In several cases, only a few Blocks were changed, and there was no need to go over the whole graph, but until now there was no less blunt tool for verification than IR::verify.
>> 
>> This PR introduces IR::verify_local, intended to be used when only a defined set of blocks have been modified. As a complement, expand_with_neighbors provides a way to also capture the neighbors of the "modified set" ahead of modification, so that afterwards the appropriate asserts can be made on all blocks which might possibly have been changed. All this should let us remove the expensive IR::verify calls, while still performing equivalent (or stricter) assertions.
>> 
>> Some changes have been made in the verifiers along the way. Some amount of refactoring, and even added invariants (see validate_edge_mutiality).
>
> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   flip ifs

I wonder if "map fusion" works here, as in improving the perf of verification.

Using `IR::verify_local` as an example:


{
  VerifyClosure cl;
  blocks.iterate_forward(&cl);
}

class VerifyClosure : public BlockClosure {

  void block_do(BlockBegin* block) override {
    verify_end_not_null(block);
    
    verify_edge_mutuality(block);
    
    verify_block_begin_field(block);
    
    // more verifier
  }
}


This should cut down #iteration to 1.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850