RFR: 8260296: SA's dumpreplaydata fails [v3]

[Roland Westrelin]

On Wed, 3 Feb 2021 05:45:02 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - convert all tests
>>  - Merge branch 'master' into JDK-8260296
>>  - use CoreUtils
>>  - whitespaces
>>  - SA fixes
>>  - VM fix
>>  - test
>
> test/lib/jdk/test/lib/process/ProcessTools.java line 461:
> 
>> 459:     }
>> 460: 
>> 461:     static public class OutputAnalyzerAndPID {
> 
> can we either change `OutputAnalyzer` to store pid (and use -1 for cases when there is no one) or make `OutputAnalyzer` non-final and have `OutputAnalyzerAndPID` extending `OutputAnalyzer`?

Thanks for reviewing this. I did not store the pid in the OutputAnalyzer because it doesn't seem to belong there as it has nothing to do with the text output of a test. But if you think that's ok. that's fine with me too. Do you prefer an extra field in OutputAnalyzer or a new subclass?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2195