RFR: 8260296: SA's dumpreplaydata fails [v3]

[Igor Ignatyev]

On Wed, 3 Feb 2021 12:04:00 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> test/lib/jdk/test/lib/process/ProcessTools.java line 461:
>> 
>>> 459:     }
>>> 460: 
>>> 461:     static public class OutputAnalyzerAndPID {
>> 
>> can we either change `OutputAnalyzer` to store pid (and use -1 for cases when there is no one) or make `OutputAnalyzer` non-final and have `OutputAnalyzerAndPID` extending `OutputAnalyzer`?
>
> Thanks for reviewing this. I did not store the pid in the OutputAnalyzer because it doesn't seem to belong there as it has nothing to do with the text output of a test. But if you think that's ok. that's fine with me too. Do you prefer an extra field in OutputAnalyzer or a new subclass?

`OutputAnalyzer`/ `OutputBuffer` already have an exit value, which arguable has nothing to do w/ the text output either, so I think it's ok to add a pid into `OutputBuffer` i-face and both of its implementations.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2195