RFR: 8261137: Optimization of Box nodes in uncommon_trap [v2]

Xin Liu xliu at openjdk.java.net
Tue Feb 9 00:59:44 UTC 2021


On Mon, 8 Feb 2021 18:15:54 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor codes
>
> src/hotspot/share/opto/callGenerator.cpp line 582:
> 
>> 580:         Node* uncommon_trap_node = delay_boxes.pop();
>> 581:         int in_edge = uncommon_trap_node->find_edge(res);
>> 582:         assert(in_edge > 0, "sanity");
> 
> If there are several references you need to replace all of them.

+1
scalar replacement uses range substitution
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/macro.cpp#L892

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list